chore: exclude sampleRUM from coverage #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the test. We should pull this into helix-rum-js |
This was referenced Sep 12, 2023
Closed
|
Ok, I have updated the PR to exclude rum.js from coverage since the code will come from https://github.com/adobe/helix-rum-js (tracked in #2). I have also created a draft PR to initiate the testing work on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - sampleRUM first basic test
@trieloff I am not sure on how to test all sampleRUM capabilities and features. It would be great if you could write tests to reach 100% of coverage (currently 71%).
Note that the change to
web-test-runner.config.jshas to be reverted once 100% is hit. Testing only the rum code is the easiest solution I have found to know the current coverage on the rum area.