Skip to content
This repository has been archived by the owner on Feb 19, 2020. It is now read-only.

Text component cannot be updated using the dialog after inline edit #18 #19

Merged
merged 3 commits into from
Dec 7, 2018
Merged

Text component cannot be updated using the dialog after inline edit #18 #19

merged 3 commits into from
Dec 7, 2018

Conversation

habansal
Copy link
Contributor

@habansal habansal commented Dec 7, 2018 •
edited
Loading

Addresses #18

@habansal habansal mentioned this pull request Dec 7, 2018
Closed
@habansal habansal requested review from lydiapuric and pfauchere and removed request for pfauchere December 7, 2018 10:14
lydiapuric
lydiapuric approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@lydiapuric lydiapuric left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, Tested in Angular and React manually.

@habansal habansal merged commit 6aa2c9d into development Dec 7, 2018
@habansal habansal deleted the issues/18 branch December 7, 2018 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pfauchere pfauchere pfauchere approved these changes

@lydiapuric lydiapuric lydiapuric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@habansal @pfauchere @lydiapuric