This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Possible fix for #1473 (Uninstaller doesn't always remove Brackets start menu shortcut) #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t from previous sprints, which should disentangle the Component ref counts and allow uninstalling the two shortcuts independently.
|
Let's give it a shot. Merging. |
gruehle
added a commit
that referenced
this pull request
Oct 26, 2012
Possible fix for #1473 (Uninstaller doesn't always remove Brackets start menu shortcut)
gruehle
added a commit
that referenced
this pull request
Dec 8, 2015
Possible fix for #1473 (Uninstaller doesn't always remove Brackets start menu shortcut)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for bug adobe/brackets#1473: use a different GUID for StartMenuShortcut from previous sprints, which should disentangle the Component ref counts and allow uninstalling the two shortcuts independently.
This fix was suggested by @RajNarayana, and I've found some other small references to this as well. I did a brief test and it appears to fix the problem on the build machine when there are side-by-side installs.
I don't think we should actually close 1473 right away, though -- given how inconsistently reproducible it's been, we should wait until Sprint 16 ends and we can verify this more broadly on various different computers. At that point we can also consider whether to automate the GUID changing or just add it to the sprint checklist.