Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

CodeHintManager unit tests #3223

Closed
iwehrman opened this issue Mar 22, 2013 · 3 comments
Closed

CodeHintManager unit tests #3223

iwehrman opened this issue Mar 22, 2013 · 3 comments
Assignees
Milestone

Comments

@iwehrman
Copy link
Contributor

Previously, commit 5878608 broke code hint provider selection (later fixed by #3208). This went unnoticed for two weeks because there are no unit tests for the CodeHintManager.

There should be CodeHintManager unit tests for:

  1. provider registration;
  2. provider selection by language and priority, including tests for the special "all" language mode; and
  3. session creation and destruction.
@pthiess
Copy link
Contributor

pthiess commented Mar 22, 2013

Reviewed - @RaymondLim , Medium Priority - we'd want to improve that before we touch the CodeHintMgr. again.

@RaymondLim
Copy link
Contributor

Reassign it to @peterflynn

@RaymondLim
Copy link
Contributor

Unit tests reviewed and ran.

@iwehrman I'm closing it since the new test cases with 2 old test cases cover all you've listed, but you can always double-check if you'd like.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants