This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Small CodeHintManager cleanups #3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r it. Fix various Closure docs glitches. Make capitalization of "Id" consistent (does NOT change public API).
|
@RaymondLim would you care to review? These are just a few small things I ran across earlier today & thought I'd clean up. |
ghost
assigned 
| CodeHintManager; | ||
|
|
||
| var testPath = SpecRunnerUtils.getTestPath("/spec/CodeHint-test-files"), | ||
| testWindow, | ||
| initCodeHintTest; | ||
|
|
||
| describe("Code Hint Menus", function () { | ||
| describe("CodeHintManager", function () { |
There was a problem hiding this comment.
Thanks for renaming this unit test. Using the module name will help us all to easily locate the unit test.
|
Nice cleanup and addition of three new test cases. These test cases do cover the issue #3223. |
|
Everything looks good. Merging. |
RaymondLim
added a commit
that referenced
this pull request
May 13, 2013
Small CodeHintManager cleanups
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up CodeHintManager.registerHintProvider() and add a couple unit tests for it. Fix various docs glitches (mainly Closure syntax issues). Make capitalization of "Id" consistent (does not change public API).