Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

JavaScript hint sorting should prefer local variables #3643

Closed
iwehrman opened this issue Apr 26, 2013 · 4 comments
Closed

JavaScript hint sorting should prefer local variables #3643

iwehrman opened this issue Apr 26, 2013 · 4 comments
Assignees
@dangoor
Labels
fixed but not closed
Milestone
sprint 25

Comments

@iwehrman
Copy link
Contributor

The JavaScript hinter does not appear to prefer local variables over other variables and keywords. That seems likes it would be a reasonable heuristic. For example:

"default"

If this turns out to be Tern.js bug then I'm happy to refile there, but I thought the @adobe-research folks might also have some thoughts.
@dloverin
Copy link

I agree this is a problem. The stringMatcher is not setting all of the prefix matches to the same value so "deferred" is not being sorted to the top in the secondary sort. Kevin had a fix #3588 (comment) that might not make it in Sprint 24.

@njx njx mentioned this issue May 3, 2013
Merged
@ghost ghost assigned dangoor May 3, 2013
@njx
Copy link
Contributor

njx commented May 3, 2013

Reviewed. To @dangoor for sprint 25 since it looks like he already has a fix for this.

@dangoor dangoor mentioned this issue May 10, 2013
Open
@njx
Copy link
Contributor

njx commented May 14, 2013

Looks like this was fixed by #3588. FBNC @iwehrman

@iwehrman
Copy link
Contributor Author

Works great, thanks!

@core-ai-bot core-ai-bot mentioned this issue Aug 29, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dangoor dangoor

Labels
fixed but not closed
Projects
None yet
Milestone
sprint 25
Development

No branches or pull requests
4 participants
@dangoor @njx @iwehrman @dloverin