Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] JavaScript hint sorting should prefer local variables #3418

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments
Open

[CLOSED] JavaScript hint sorting should prefer local variables #3418

core-ai-bot opened this issue Aug 29, 2021 · 4 comments

Comments

@core-ai-bot
Copy link
Member

Issue by iwehrman
Friday Apr 26, 2013 at 18:56 GMT
Originally opened as adobe/brackets#3643


The JavaScript hinter does not appear to prefer local variables over other variables and keywords. That seems likes it would be a reasonable heuristic. For example:

"default"

If this turns out to be Tern.js bug then I'm happy to refile there, but I thought the@adobe-research folks might also have some thoughts.

@core-ai-bot
Copy link
Member Author

Comment by dloverin
Friday Apr 26, 2013 at 19:11 GMT


I agree this is a problem. The stringMatcher is not setting all of the prefix matches to the same value so "deferred" is not being sorted to the top in the secondary sort. Kevin had a fix adobe/brackets#3588 (comment) that might not make it in Sprint 24.

@core-ai-bot
Copy link
Member Author

Comment by njx
Friday May 03, 2013 at 20:16 GMT


Reviewed. To@dangoor for sprint 25 since it looks like he already has a fix for this.

@core-ai-bot
Copy link
Member Author

Comment by njx
Tuesday May 14, 2013 at 22:54 GMT


Looks like this was fixed by #3588. FBNC@iwehrman

@core-ai-bot
Copy link
Member Author

Comment by iwehrman
Tuesday May 14, 2013 at 23:29 GMT


Works great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant