Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

"Pixels" is hard-coded for image size in Quick View of images. #3713

Closed
RaymondLim opened this issue May 3, 2013 · 5 comments
Closed

"Pixels" is hard-coded for image size in Quick View of images. #3713

RaymondLim opened this issue May 3, 2013 · 5 comments
Assignees
Milestone

Comments

@RaymondLim
Copy link
Contributor

  1. Switch language to Spanish or Japanese that has a different word for "pixels". Don't use German or French as they use the same word (maybe without "s").
  2. Move mouse over a string that has a valid image file path that points to an existing image file.

Result: You will see Quick View of the image with English word "pixels."

kjgorman added a commit to kjgorman/brackets that referenced this issue May 4, 2013
@kjgorman
Copy link
Contributor

kjgorman commented May 4, 2013

Not so sure about how you prefer the placement of the master string key, or if unit_pixels is a reasonable name, but at any rate that's the line of code to change, for future reference.

@njx
Copy link
Contributor

njx commented May 13, 2013

Reviewed. @kjgorman - could you submit this as a pull request for us to review? Thanks.

@ghost ghost assigned gruehle May 13, 2013
@njx
Copy link
Contributor

njx commented May 13, 2013

Medium priority to @gruehle to track.

@kjgorman
Copy link
Contributor

Pull request here

@gruehle
Copy link
Member

gruehle commented May 13, 2013

Fixed. Thanks @kjgorman !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants