[FindInFiles] Search results are not sorted.

[zaggino]

[TomMalbran]

I have a fix for this in #3151. I will get to make a new PR with a fix for this soon, probably after #4729 is merged.

[zaggino]

Great 👍

[njx]

Opening to @TomMalbran since he has a fix - thanks!

[TomMalbran]

FBNC. @zaggino Want to test it in the latest master and close it?

[zaggino]

Two minor things @TomMalbran , when searching for define( in the brackets repo.

1. First is currently opened file, then list continues as sorted.
   
2. Nested folders are before their parents.
   

But I'm not sure I'd call 1) an issue because it's maybe on purpose and if 2) would take more than 5 mins. to fix I wouldn't care about that either.

[TomMalbran]

1. Is designed like that. The idea is that you can see the results from the current file first. It was requested long time ago.

2. I made the sort work in the same way as it is in the file tree when is completely open. As on the file tree you first see the children directories and then the files. I thought it made more sense like that. But not sure how long it would take to change it.

[TomMalbran]

If users don't like how 1 works. That is easy to remove.

[redmunds]

@TomMalbran Note that file tree sorting is different on Win/Linux than it is on Mac.

[TomMalbran]

I know. But we are sorting file paths here and the way it is done in mac wouldn't make much sense in this content. Maybe the way zaggino mentioned migth make more sense. I will check later if it is easy to change and how it looks.

[zaggino]

As I said, I think it's fine now, just wanted to point out two things I noticed. We can close if nobody else objects.

[TomMalbran]

Well, let me know if you want it fixed, or if not, you can close this issue :)