[CLOSED] [FindInFiles] Search results are not sorted.

[core-ai-bot]

Issue by zaggino
Sunday Aug 25, 2013 at 00:29 GMT
Originally opened as adobe/brackets#4933

---

[core-ai-bot]

Comment by TomMalbran
Sunday Aug 25, 2013 at 00:34 GMT

---

I have a fix for this in #3151. I will get to make a new PR with a fix for this soon, probably after #4729 is merged.

[core-ai-bot]

Comment by zaggino
Sunday Aug 25, 2013 at 00:50 GMT

---

Great 👍

[core-ai-bot]

Comment by njx
Monday Sep 09, 2013 at 17:54 GMT

---

Opening to@TomMalbran since he has a fix - thanks!

[core-ai-bot]

Comment by TomMalbran
Friday Mar 07, 2014 at 18:53 GMT

---

FBNC.@zaggino Want to test it in the latest master and close it?

[core-ai-bot]

Comment by zaggino
Friday Mar 07, 2014 at 21:36 GMT

---

Two minor things@TomMalbran , when searching for define( in the brackets repo.

1. First is currently opened file, then list continues as sorted.
   
2. Nested folders are before their parents.
   

But I'm not sure I'd call 1) an issue because it's maybe on purpose and if 2) would take more than 5 mins. to fix I wouldn't care about that either.

[core-ai-bot]

Comment by TomMalbran
Friday Mar 07, 2014 at 21:50 GMT

---

1. Is designed like that. The idea is that you can see the results from the current file first. It was requested long time ago.

2. I made the sort work in the same way as it is in the file tree when is completely open. As on the file tree you first see the children directories and then the files. I thought it made more sense like that. But not sure how long it would take to change it.

[core-ai-bot]

Comment by TomMalbran
Friday Mar 07, 2014 at 21:52 GMT

---

If users don't like how 1 works. That is easy to remove.

[core-ai-bot]

Comment by redmunds
Friday Mar 07, 2014 at 22:33 GMT

---

@TomMalbran Note that file tree sorting is different on Win/Linux than it is on Mac.

[core-ai-bot]

Comment by TomMalbran
Friday Mar 07, 2014 at 22:50 GMT

---

I know. But we are sorting file paths here and the way it is done in mac wouldn't make much sense in this content. Maybe the way zaggino mentioned migth make more sense. I will check later if it is easy to change and how it looks.

[core-ai-bot]

Comment by zaggino
Friday Mar 07, 2014 at 23:09 GMT

---

As I said, I think it's fine now, just wanted to point out two things I noticed. We can close if nobody else objects.

[core-ai-bot]

Comment by TomMalbran
Saturday Mar 15, 2014 at 02:02 GMT

---

Well, let me know if you want it fixed, or if not, you can close this issue :)