Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Editor-related HTML menus are non-functional #5310

Closed
busykai opened this issue Sep 23, 2013 · 2 comments
Closed

Editor-related HTML menus are non-functional #5310

busykai opened this issue Sep 23, 2013 · 2 comments

Comments

@busykai
Copy link
Contributor

busykai commented Sep 23, 2013

The HTML menus associated with the actions on the current editor (copy, paste, select etc.) are not functional. To reproduce: change the line in src/utils/Global.js from

    global.brackets.nativeMenus = (!global.brackets.inBrowser && (global.brackets.platform !== "linux"));

to

    global.brackets.nativeMenus = false;

start the editor and try any of the above mentioned menu items, e.g. Select All.

@busykai
Copy link
Contributor Author

busykai commented Sep 23, 2013

The root cause of this is that bootstrap implementation of dropdown (used to implement the HTML menu) is calling $(this).focus() explicitly which, in turn, causes current CM instance to lose the focus and the command cannot get the current editor instance to act upon.

@RaymondLim
Copy link
Contributor

@busykai Nice catch! This was broken when we updated bootstrap to the newer version in sprint 26.

RaymondLim added a commit that referenced this issue Sep 24, 2013
Fix #5310 (Editor HTML menus are broken).
busykai added a commit to busykai/brackets that referenced this issue Sep 26, 2013
As per discussion in PR adobe#5311, related to issue adobe#5310.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants