Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[preview image] Some display issues for image info in preview image. #5686

Closed
RaymondLim opened this issue Oct 25, 2013 · 7 comments
Closed

Comments

@RaymondLim
Copy link
Contributor

Select an image file in side bar to preview it in editor area. I used the image in default "Getting Started" project by expanding screenshot folder and selecting quick-edit.png.

  1. When resizing the width of the window smaller, the top two lines of text will wrap. I don't think we should wrap these two lines of image info, just let them being clipped if they don't fit inside the window width.
  2. When resizing the height of the window smaller while keeping the width wide enough, the top most line will move out of the top boundary. We are scaling the image height without excluding the height of the two lines of text.
  3. When resizing the height of the window smaller while keeping the width wide enough, scaling info is no longer displayed on top left of the image. ie. it jumps out of the image and showing in a position far away from the scaled image. Its initial position is also not consistent; it is inside the image if the image width is larger than height, but If the width of the image is a lot smaller, then its initial position is not inside the image. I think we should have it positioned in the first line of text. Maybe next to the image file size.
@ghost ghost assigned couzteau Oct 25, 2013
@njx
Copy link
Contributor

njx commented Oct 25, 2013

To @couzteau, low priority.

@couzteau
Copy link
Member

couzteau commented Nov 5, 2013

@RaymondLim I'll consult @larz0 on these issues.

couzteau pushed a commit that referenced this issue Nov 6, 2013
1. make image meta data strings not wrap
2. add ellipsis to image meta data when clipping
3. add title attribute to allow viewing the full path and meta data when text is clipped.
@couzteau
Copy link
Member

couzteau commented Nov 6, 2013

#3 has been fixed by #5875

@couzteau
Copy link
Member

couzteau commented Nov 6, 2013

#5877 has been posted to address 1)

I don't know how to fix 2) yet.

@couzteau
Copy link
Member

couzteau commented Nov 6, 2013

@RaymondLim please verify the fixes for 1) and 3) if you think these are sufficiently fixed the bug description can be updated.

@RaymondLim
Copy link
Contributor Author

@couzteau #3 is still not fixed with changes in css. You still can see the issue if you start it with normal Brackets window size, then reduce the height and increase the width. After that you see the scale div outside of the image.

For #2 you just have to remove margin-top: -50px; from #img-centering.

@couzteau
Copy link
Member

couzteau commented Nov 6, 2013

@RaymondLim thanks - I'll take a look at your pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants