Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Update zh-TW translation #11655

Merged
merged 11 commits into from
Sep 16, 2015
Merged

Update zh-TW translation #11655

merged 11 commits into from
Sep 16, 2015

Conversation

tan9
Copy link
Contributor

@tan9 tan9 commented Sep 1, 2015

  1. Add missed entry in urls.js.
  2. Align to latest root version.
  3. Refine transalations.

@tan9
Copy link
Contributor Author

tan9 commented Sep 1, 2015

Travis CI failed as cla-check-pull task:

Running "cla-check-pull" task
Unexpected response from api.github.com
statusCode: 403

I singed the CLA as per described in CONTRIBUTING.md. Am I missing anything?

@rroshan1
Copy link
Contributor

rroshan1 commented Sep 2, 2015

@tan9 I just had to restart the Travis CI build after you signed the CLA. The build has all checks passed now.
Before we can merge your changes, can you tag someone for linguistic review?

@marcelgerber
Copy link
Contributor

@yiming @jenghung @lyhcode Could you please take a look at @tan9's translation?

@tan9
Copy link
Contributor Author

tan9 commented Sep 3, 2015

Do you have something like Last Call for 1.5 Translations?
Maybe we should wait until then, and find more reviewers on refining this PR.

@nethip
Copy link
Contributor

nethip commented Sep 9, 2015

@tan9 Yes we will be doing 1.5 release in a couple of weeks and that is when we will call for translations. Nevertheless, if it looks good we should push this anyway to master.

@abose abose added this to the Release 1.5 milestone Sep 11, 2015
@ingorichter
Copy link
Contributor

It would be great to have another pair of eyes on this PR. As @marcelgerber already asked for help, is @yiming or @jenghung or @lyhcode available for a review? Thanks.

您應該就會看到 CSS 快速編輯器出現在上方,馬上就能看到並修改套用在該標籤上的 CSS 規則。
快速編輯功能也支援 class 及 id 屬性喔!
您應該就會看到 CSS 快速編輯器出現在上方,顯示出所有套用到的 CSS 規則。
快速編輯功能也支援 class 及 id 屬性。搭配 LESS 或 SCSS 檔嘛會通喔。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some people will confuse "嘛會通喔" if they are not familiar with Taiwanese Hokkien.

@jenghung
Copy link

I reviewed @tan9 commits and most of translations is appropriate. I left some comments above. Thanks @tan9 make the zh-TW translation better!

abose added a commit that referenced this pull request Sep 16, 2015
@abose abose merged commit ac23edb into adobe:master Sep 16, 2015
@abose
Copy link
Contributor

abose commented Sep 16, 2015

Thanks all. Merging for 1.5 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants