-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Remove unneeded CSS prefixes and length unit symbols #12163
Conversation
LGTM |
@valtlait The original email notification I received said this:
But message in PR now says this:
It looks like it was edited to remove "and empty lines". But, I still see lines with only whitespace that were edited to remove whitespace in this PR. Please backout those changes and rebase into a single commit. Thanks. In general: Yes, please remove whitespace from the end of non-empty lines. Please do not remove whitespace from empty lines. This is not part of the Brackets coding conventions. It's optional based on developer tastes. It doesn't do any good to remove it because the next dev might put it back. Worst of all, the change will show up as a merge conflict for the next poor soul that edits a line near that change, so it causes unnecessary pain. Exception: whitespace on empty lines should be at correct indentation level, so it's ok to correct that. But no need to scan files for this -- just correct it in code blocks that you are editing for some other reason. |
FWIW There was discussion about this on #11998 too and @peterflynn suggested (for the code) |
Reverted whitespace changes for empty lines. |
@valtlait Thank you! |
@@ -511,8 +511,7 @@ a, img { | |||
margin-bottom: 0; | |||
.sprite-icon(0, 0, 13px, 13px, "images/flip-view-icons.svg"); | |||
background-origin: content-box; | |||
-webkit-transform: translateZ(0); // forces GPU mode for better filter rendering on retina | |||
transform: translateZ(0); // future proofing | |||
transform: translateZ(0); // forces GPU mode for better filter rendering on retina |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that the Linux build of Brackets Shell is sadly still based on CEF 1547 (~ Chrome 29), so you still need these prefixes (and probably others, too) according to caniuse.com
|
* Remove `-webkit-` prefixes from `transition` and flexbox-related properties * Remove `-webkit-` prefix inside unprefixed `@keyframes` * Add missing unprefixed `transform`s * Remove `px` unit from `0px` values (+ Remove whitespace from end of lines)
@@ -220,8 +220,8 @@ a, img { | |||
|
|||
#status-language { | |||
border-right: 1px solid @bc-panel-border; | |||
padding: 0px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious. Why did you removed the units from all 0s?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MiguelCastillo There’s a practice to leave off the unit from zero length values. That makes the code look slightly cleaner.
@valtlai could you update the PR? |
# Conflicts: # src/styles/brackets.less
@ficristo Updated. |
@valtlai the merge didn't end well, can you check? |
Replaced with #12648. |
-webkit-
prefixes fromtransition
and flexbox-related properties-webkit-
prefix inside unprefixed@keyframes
transform
spx
unit from0px
values(+ Remove whitespace from end of lines)