Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Create index.html #13446

Closed
wants to merge 1 commit into from
Closed

Create index.html #13446

wants to merge 1 commit into from

Conversation

FallingHeart
Copy link
Contributor

zh-cn

@FallingHeart
Copy link
Contributor Author

a Chinese translation

@FallingHeart
Copy link
Contributor Author

FallingHeart commented Jun 15, 2017

@travis-ci

@ficristo
Copy link
Collaborator

FallingHeart has NOT submitted the contributor license agreement. See http://dev.brackets.io/brackets-contributor-license-agreement.html.

@FallingHeart
Copy link
Contributor Author

i get a license @ficristo

@ficristo
Copy link
Collaborator

@FallingHeart do you know someone who could review this ?
I think you are missing an entry in src/nls/zh-cn/urls.js: something like: "GETTING_STARTED" : "zh-cn/Getting Started".
You could also translate the Getting Started words if you want (and the link should be reflected in the GETTING_STARTED above)

@ficristo ficristo mentioned this pull request Jun 18, 2017
@FallingHeart
Copy link
Contributor Author

i am really sorry because i am totally a freshman here
and due to my poor english
i can not really understand what you are talking about
what does it mean by a single PR
what does PR stand for

@ficristo
Copy link
Collaborator

PR stands for Pull Request, what you have here is a pull request. You can think it as a request to merge your code.
Based on the branch names (patch-1 and patch-2) it seems to me you have used GitHub interface to create these PR. If I remember correctly GitGub interface doesn't allow you to modify more than one file.
Ideally you should have used a local clone of Brackets to change both files and do a single PR with both files modified. But you should also know / learn git commands to do it.

PS: my english is not really good either, I hope to have been clearer.

@ficristo
Copy link
Collaborator

Superceded by #13473

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants