Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Added italian translation #1711

Merged
merged 3 commits into from
Oct 1, 2012
Merged

Added italian translation #1711

merged 3 commits into from
Oct 1, 2012

Conversation

antonellopasella
Copy link
Contributor

No description provided.

@ghost ghost assigned jasonsanjose Oct 1, 2012
@jasonsanjose
Copy link
Member

In review

@@ -0,0 +1,139 @@
<!DOCTYPE html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is still in english. Did you intend to translate this to italian? If you don't translate it, then you should revert your change to src/nls/urls.js.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I'll try to translate tomorrow, otherwise I'll revert my change

@jasonsanjose
Copy link
Member

Hi @antonellopasella. Before continuing please sign the Brackets CLA http://dev.brackets.io/brackets-contributor-license-agreement.html.

"ABOUT" : "About",
"APP_NAME" : "Brackets",
"CLOSE" : "Chiudi",
"ABOUT_TEXT_LINE1" : "sprint 14 experimental build ",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to sprint 15

@jasonsanjose
Copy link
Member

Initial review complete

Fixed some typos and some missing lines
@antonellopasella
Copy link
Contributor Author

Edited my master branch. It's enough?

Thanks for the kind review

@jasonsanjose
Copy link
Member

Yes, and thanks for signing the CLA. Your changes look good. Thanks for the contributions!

If you like, you can revert the src/nls/urls.js change and I can merge it now. Otherwise, I will wait and merge it when the getting started content is translated. I'll let you choose. Thanks.

Reverted. I'll try to fix the italian translation of the "welcome page" tomorrow.
@antonellopasella
Copy link
Contributor Author

Reverted. I'll add a new pull request ASAP :D

p.s. the "revert" is correct or there is a better way to do a real revert?

Thanks!

@jasonsanjose
Copy link
Member

Revert worked. Merging now.

jasonsanjose added a commit that referenced this pull request Oct 1, 2012
@jasonsanjose jasonsanjose merged commit eef438a into adobe:master Oct 1, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants