Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

"Show in Tree" command #1823

Merged
merged 2 commits into from
Oct 12, 2012
Merged

"Show in Tree" command #1823

merged 2 commits into from
Oct 12, 2012

Conversation

peterflynn
Copy link
Member

  • General purpose ProjectManager.showInTree() API (any file/folder)
  • "Show in Tree" command (current file)
  • Utility for searching arrays (new CollectionUtils module): used in new code plus to clean up an older DocumentManager method

- General purpose showInTree() API (any file/folder)
- "Show in Tree" command (current file)
- Utility for searching arrays (new CollectionUtils module): used in new
  code plus cleans up a DocumentManager method
@@ -195,6 +195,7 @@ define({
"CMD_QUICK_EDIT_NEXT_MATCH" : "Next Match",
"CMD_NEXT_DOC" : "Next Document",
"CMD_PREV_DOC" : "Previous Document",
"CMD_SHOW_IN_TREE" : "Show in Tree",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a little generic. Maybe "Show in Project Tree" or "Show in Project Panel"?

@redmunds
Copy link
Contributor

Nice work! Done with initial review.

- Fix bug in _findTreeNode(): return rejected Promise instead of null when
  path lies outside project tree
@peterflynn
Copy link
Member Author

Fixes pushed.

NJ suggested "Show in File Tree," so I went with that and renamed the command accordingly since that was named equally generically.

I also realized that the "file not within project" case should also be returning the Promise, so I fixed that and only moved treeAPI lower down.

@redmunds
Copy link
Contributor

Looks good. Merging.

redmunds added a commit that referenced this pull request Oct 12, 2012
@redmunds redmunds merged commit b1d87a6 into master Oct 12, 2012
@ychaikin
Copy link

"Show in File Tree" seems to be a something you have to go to over and over. Is there a way to make it a toggle, so it's always on if you want that way. Currently, the highlighting switching to the "Working Files", so it's no longer "in File Tree". To get it back there, you have to manually go to Navigate->Show in File Tree.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants