Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Changed to check for case insensitive http: and https: #3019

Merged
merged 3 commits into from
Mar 5, 2013
Merged

Changed to check for case insensitive http: and https: #3019

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
460795f
Changed to check for case insensitive http: and https:
WebsiteDeveloper Mar 2, 2013
cbd2c63
Added check for end and beginning of the string
WebsiteDeveloper Mar 3, 2013
b93f1cd
Fixed another case where the previous check passed
WebsiteDeveloper Mar 3, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/preferences/PreferencesDialogs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@ define(function (require, exports, module) {
var obj = PathUtils.parseUrl(url);
if (!obj) {
result = Strings.BASEURL_ERROR_UNKOWN_ERROR;
} else if (obj.protocol !== "http:" && obj.protocol !== "https:") {
result = StringUtils.format(Strings.BASEURL_ERROR_INVALID_PROTOCOL, obj.protocol);
} else if (obj.href.search(/^(http|https):\/\//i) !== 0) {
result = StringUtils.format(Strings.BASEURL_ERROR_INVALID_PROTOCOL, obj.href.substring(0, obj.href.indexOf("//")));
} else if (obj.search !== "") {
result = StringUtils.format(Strings.BASEURL_ERROR_SEARCH_DISALLOWED, obj.search);
} else if (obj.hash !== "") {
Expand Down