Add CollectionUtils.some() to allow breaking out of iteration

[TomMalbran]

Since we will be using this function a lot more, this change would make it really useful to do a search inside an object and stop when finding the result by making the callback return a value that will be false once the search is done. This is the same way that jQuery uses to break the .each loops.

[njx]

To @peterflynn

[TomMalbran]

An alternative to this could be a new CollectionUtils.some function that could call Object.keys().some() or use a for loop and break it if the callback return true, to make a function to loop over Objects similar to Array.some. Reference: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Array/some

[TomMalbran]

I've been using Array.some a lot more lately and it seems useful to have a return value, so I removed the break in forEach and added a new some function, which also makes it more consistence with the Array functions.

[peterflynn]

Typo: "inmediatelly" -> "immediately"

[peterflynn]

@TomMalbran done reviewing. Two comment nits plus this bigger question about whether we want to rename the API. We should probably wait a day or so to see if others chime in on that.

[TomMalbran]

It seems like I missed several cases when switching $.each with forEach where the loop broke. This fixes one of those cases, since it needs CollectionUtils.some to work.

[TomMalbran]

@peterflynn It's been a few days, and nothing happened, should we just leave like it is. The names make sense since the functions work for any collection, and JavaScript already implements different APIs with the same names.

[peterflynn]

Clarifying title (was: "Break the CollectionUtils.forEach loop if the callback returns false")

[TomMalbran]

@peterflynn Great, I am glad that this is finally merged :) I know it shouldn't be used for arrays, but it is possible. It would work great when the object could be either an array or an object. Thanks for changing the name, this pull went from breaking the loop to creating a new method.

[peterflynn]

Yeah -- thanks for generalizing it that way btw. We will definitely have more places to use this :-)