This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Hover Preview: Ignore w3c gradient syntax not yet supported in Chrome 25 #3482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Reviewing ... |
|
@RaymondLim I have 1 more fix for this pull request, so don't merge yet. |
|
@RaymondLim Go ahead and review this pull request as it is. The other change is not easy, and will likely conflict with PeterF's pull request, so I'm going to fix some other bugs first. |
|
Looks good. You submit this pull request without logging an issue and @peterflynn just logged one #3535 not knowing that you're fixing it. Merging |
RaymondLim
added a commit
that referenced
this pull request
Apr 22, 2013
Hover Preview: Ignore w3c gradient syntax not yet supported in Chrome 25
peterflynn
added a commit
that referenced
this pull request
Apr 22, 2013
…w-delay - Be more explicit about testing the fix in pull #3482 - Add simple test for matched-text highlighting in UI - Cite bug numbers for all disabled tests * origin/master: fix unit tests for changes in this branch remove misguided attempt to filter gradients for Chrome 25 code cleanup ignore new gradient syntax, for now ignore new gradient syntax Conflicts: src/extensions/default/HoverPreview/main.js src/extensions/default/HoverPreview/unittests.js
|
I didn't log an issue because this is for the "Preview gradients (as specified in Criteria)" Task. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until Brackets is upgraded to Chrome 26, Hover Preview needs to:
2. Ignore gradients with new color stop syntax (i.e.Misguided theory.<color> <length>)Note that some Hover Preview unit tests
will need to bewere updated for this change.This mitigates #3458