This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix unit tests broken by modal bar animation #4800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -214,74 +226,89 @@ define(function (require, exports, module) { | |||
| }); | |||
|
|
|||
| it("should Find Next after search bar closed, including wraparound", function () { | |||
There was a problem hiding this comment.
Most of these changes were just to wrap runs() blocks around code that originally did expectSearchBarClosed().
|
I highly recommend reviewing with |
|
@gruehle or @peterflynn--interested in taking this one? Want to get it checked in today since the unit tests are broken. Note that this does mean that the timing of when modal bars appear/disappear has changed...but I'm inclined not to worry about it too much unless we find actual user-visible issues. |
|
Oops, retagging @peterflynn |
|
For #4797 |
|
Looks good. Merging. |
gruehle
added a commit
that referenced
this pull request
Aug 16, 2013
Fix unit tests broken by modal bar animation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modal bar animation added by @larz0 added a bit of asynchronicity to the modal bar: it now isn't removed from the DOM until the close animation completes. This pull request fixes up the unit tests so that they wait for the previous modal bar to close (and forcibly remove it at the end of the test) before continuing.
Also, some unit tests were breaking because the modal bar was never removing itself from the DOM. This was due to a subtle issue: the new modal bar code was using the
.hideclass, but that class is also defined by Bootstrap to setdisplay: none. That wasn't affecting the modal bar's behavior in Brackets itself, but was affecting it in the test runner, possibly because stylesheets are loaded in a different order. So I just renamed the class to.modal-bar-hideto avoid getting contaminated by the Bootstrap rule.