Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Don't show overwrite animation on click #6883

Merged
merged 2 commits into from
Mar 10, 2014
Merged

Don't show overwrite animation on click #6883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec34995
Don't show animation on click
WebsiteDeveloper Feb 15, 2014
7b5af95
Change to leave event handlers in place
WebsiteDeveloper Mar 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions src/editor/EditorStatusBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,16 +143,26 @@ define(function (require, exports, module) {
_updateCursorInfo();
}

function _updateOverwriteLabel(event, editor, newstate) {
function _updateOverwriteLabel(event, editor, newstate, doNotAnimate) {
if ($statusOverwrite.text() === (newstate ? Strings.STATUSBAR_OVERWRITE : Strings.STATUSBAR_INSERT)) {
// label already up-to-date
return;
}

$statusOverwrite.text(newstate ? Strings.STATUSBAR_OVERWRITE : Strings.STATUSBAR_INSERT);

AnimationUtils.animateUsingClass($statusOverwrite[0], "flash");

if (!doNotAnimate) {
AnimationUtils.animateUsingClass($statusOverwrite[0], "flash");
}
}

function _updateEditorOverwriteMode() {
var editor = EditorManager.getActiveEditor();

editor.toggleOverwrite(null);

function _updateEditorOverwriteMode(event) {
var editor = EditorManager.getActiveEditor(),
newstate = !editor._codeMirror.state.overwrite;

// update label with no transition
_updateOverwriteLabel(event, editor, newstate, true);
editor.toggleOverwrite(newstate);
}

function _initOverwriteMode(currentEditor) {
Expand Down