This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fixes a bug in the Find in Files sorting implementation #7067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -938,6 +939,7 @@ define(function (require, exports, module) { | |||
|
|
|||
| dialog = new FindInFilesDialog(); | |||
| searchResults = {}; | |||
| selectedEntry = ProjectManager.getSelectedItem().fullPath; | |||
There was a problem hiding this comment.
If there is nothing open, then you get a runtime exception here.
There was a problem hiding this comment.
Good catch. Fixed
JeffryBooher
added a commit
that referenced
this pull request
Mar 4, 2014
Fixes a bug in the Find in Files sorting implementation
|
looks good. merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now store the selected entry when starting a search and use it when sorting the files, so that the order of the files shouldn't change anymore.
@JeffryBooher