This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Key map optimizations #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ition out of _normalizeKeyDescriptorString and into scope of KeyMap require.js module. Prior, _isModifier was defined each time _normalizeKeyDescriptorString wall called (18 time at startup). This lead to unnecessary code execution as well as garbage collection. Added an additional argument to _isModifier, origDescriptor, which is used in a debug statement within the function. _isModifier is now scoped to the KeyMap module, and thus will be in memory as long as the module is in memory.
|
Looks good, Mike. Looks like you were able to resolve the Git issues too. |
gideonthomas
pushed a commit
to gideonthomas/brackets
that referenced
this pull request
Aug 31, 2017
…dobe#824) * Shifted turn server locally * Shifted concurrently and signal-master to devDependencies * Structured npm run start command
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of _normalizeKeyDescriptorString. Moved _isModifier definition out of _normalizeKeyDescriptorString and into scope of KeyMap require.js module.
Prior, _isModifier was defined each time _normalizeKeyDescriptorString wall called (18 time at startup). This lead to unnecessary code execution as well as garbage collection.
Added an additional argument to _isModifier, origDescriptor, which is used in a debug statement within the function.
_isModifier is now scoped to the KeyMap module, and thus will be in memory as long as the module is in memory.
Ignore the README.md commits. Git got in a weird state because i forked when brackets was private.
Note : you should resquash when you pull it.