This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Added support for double clicking the project panel to close it #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -307,7 +311,6 @@ define(function (require, exports, module) { | |||
| $("#sidebar-resizer").on("mouseup.sidebar", function (e) { | |||
| $(".main-view").off("mousemove.sidebar"); | |||
| startingSidebarPosition = $sidebar.width(); | |||
| console.log(startingSidebarPosition); | |||
There was a problem hiding this comment.
I also found this stray console.log and removed it.
|
@jason-sanjose will review |
|
@ryanstewart Take a look at #845. It's easier for me to integrate this into #845 and close this pull request. |
|
Sounds good! Integrate away. |
ghost
assigned
|
Closing this since it's going to be part of #845. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found myself wanting to double click on the project panel to close it and realized I didn't support that use-case. So I added a double-click handler that will close the project panel when double clicking the re-sizer.