This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Make anchors in Quick Docs relative to page URL #8724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| url = templateVars.url + url; | ||
| } else if (url.substr(0, 4) !== "http") { | ||
| // URLs in JSON data are relative | ||
| url = "http://docs.webplatform.org" + (url.indexOf("/") !== 0 ? "/" : "") + url; |
There was a problem hiding this comment.
I'm curious as to why you changed from using url.charAt(0) !== "/" to url.indexOf("/") !== 0 ? charAt() is more efficient because it only checks the first char for a slash, where indexOf() will keep checking chars until it finds a slash or end-of-string (even though you're only interested in the first char).
There was a problem hiding this comment.
I don't know why I did that. Just changed it back.
marcelgerber
force-pushed
the
wp-docs-anchors
branch
from
26a1b54
to
eb5cb67
Compare
|
Thanks. Merging. |
redmunds
added a commit
that referenced
this pull request
Nov 13, 2014
Make anchors in Quick Docs relative to page URL
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8718.