This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Rewrite of dependencies.js #9472
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Less code + greater performance = WIN! About 0.5ms performance gain on my machine, primarly by touching the DOM just once.
|
Why is that |
|
I read that, normally, I shouldn't use a |
|
Can you merge this with |
|
My |
|
No, merge with the latest changes here in this, the main repo. Directions are on the wiki. |
|
I'll do that tomorrow, I'm on mobile now. Is that ok? |
|
Whenever you can is fine. I'm just giving you a heads up for when a dev can look at this. 😉 |
|
My repo is getting too messy. I'm forking again, and doing it right, this time (I hope) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code wasn't very optimized (8+ document.write calls!), so I rewrote it to be a little more performant.
Now I get an execution time of about 0.05ms, compared to 0.5ms before.
I just dived into Brackets' codebase, with the intention of optimizing some code (Brackets still feels a little slow), and this was an easy first pick.