This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
Clarify request url, path and introduce root #170
Labels
Comments
tripodsan
added
enhancement
New feature or request
question
Further information is requested
labels
Jan 31, 2019
Hey @tripodsan I'd say this is a good enhancement. Currently, I have no way to get the mount root in my pre.js file for my dispatcher. |
Four places I currently need the mount points:
|
+1 |
since the resource path is already available in the
|
This was referenced Feb 13, 2019
tripodsan
added a commit
that referenced
this issue
Feb 13, 2019
trieloff
pushed a commit
that referenced
this issue
Feb 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When a strain is selected with a URL condition, it is expected that the content repository is mounted below the url path. for example:
should map a request of
https://www.project-helix.io/docs/api/general/index.html?a=1
tohttps://github.com/adobe/helix-docs.git#master/documentation/general/index.md
.the
context.request
object should have:url
/docs/api/general/index.html?a=1
path
/general/index.md
root
/docs/api
Suggest
It might be confusing to have
request.path
different fromrequest.url
. so I suggest to introduceresourcePath
, and keep thepath
the original clientpath
.url
/docs/api/general/index.html?a=1
path
/docs/api/general/index.html
resourcePath
2/general/index.md
root
/docs/api
2 Alternative:
contentPath
/cc @trieloff, @kptdobe @stevengill
The text was updated successfully, but these errors were encountered: