This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
Support Internal Embeds #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far only the detection of local embeds has been implemented. As this requires access to some additional properties, many tests are broken for the time being See #267
The internal embed handler now requires access to some additional request properties that were not mocked in all test cases for #267
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 40 40
Lines 982 1039 +57
Branches 202 228 +26
=====================================
+ Hits 982 1039 +57
Continue to review full report at Codecov.
|
…tions The VDOMTransformer's `handler` functions did not allow for recursive processing of child nodes so far, i.e. when a handler function wanted to process only a single MDAST node, but hand the processing of all MDAST child nodes back to the original transformer, it had no way of doing so, making each `handler` function a terminal node. With this change, the signature of `handler` functions changes to `handler(callback, node, parent, handlechild)` where `handlechild(callback, childnode, mdastparent, hastparent)` is a callback itself that takes the current HTAST-constructing `callback`, the MDAST `childnode` that should get transformed, the `mdastparent`, i.e. the current node from the vantage point of the `handler` function, and with `hastparent` a HAST parent node that the output of the child processing will be attached to.
Until now, a failed ESI include would fail silently, without a possible fallback. This change falls back to the markdown rendered as HTML in case the ESI does not work, giving at least an approximation of the content created. fixes #267
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267