Skip to content

Commit

Permalink
fix: make targetselector null safe (#156)
Browse files Browse the repository at this point in the history
  • Loading branch information
ekremney authored Apr 18, 2024
1 parent 07325f0 commit 691d40d
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const getTargetValue = (element) => element.getAttribute('data-rum-target') || e
|| element.currentSrc || element.getAttribute('src') || element.dataset.action || element.action;

const targetselector = (element) => {
if (!element) return undefined;
let value = getTargetValue(element);
if (!value && element.tagName !== 'A' && element.closest('a')) {
value = getTargetValue(element.closest('a'));
Expand Down Expand Up @@ -117,8 +118,8 @@ function addCWVTracking() {
data.cwv[measurement.name] = measurement.value;
if (measurement.name === 'LCP' && measurement.entries.length > 0) {
const { element } = measurement.entries.pop();
data.target = sampleRUM.targetselector(element);
data.source = sampleRUM.sourceselector(element) || element.outerHTML.slice(0, 30);
data.target = targetselector(element);
data.source = sourceselector(element) || element.outerHTML.slice(0, 30);
}
sampleRUM('cwv', data);
};
Expand Down

0 comments on commit 691d40d

Please sign in to comment.