Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid CORS #183

Merged
merged 2 commits into from
Jun 4, 2024
Merged

fix: avoid CORS #183

merged 2 commits into from
Jun 4, 2024

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Jun 3, 2024

Not sure why headers is pased, it is not part of the method signature (see https://developer.mozilla.org/en-US/docs/Web/API/Navigator/sendBeacon).
body is a string, no need to wrap into a blob.

This fixes the CORS issues.

@kptdobe kptdobe requested review from trieloff and chicharr June 3, 2024 08:31
Copy link
Contributor

@trieloff trieloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the H5 implementation.

Copy link

github-actions bot commented Jun 3, 2024

This PR will trigger a patch release when merged.

@kptdobe kptdobe requested a review from trieloff June 3, 2024 09:37
@kptdobe kptdobe merged commit 4daf390 into main Jun 4, 2024
4 of 5 checks passed
@kptdobe kptdobe deleted the cors-standalone branch June 4, 2024 08:29
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
## [2.11.2](v2.11.1...v2.11.2) (2024-06-04)

### Bug Fixes

* avoid CORS ([#183](#183)) ([4daf390](4daf390))
Copy link

github-actions bot commented Jun 4, 2024

🎉 This PR is included in version 2.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants