test: set up basic test infrastructure (2.x) #191
Conversation
trieloff
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
=========================================
+ Coverage 0 47.94% +47.94%
=========================================
Files 0 1 +1
Lines 0 413 +413
=========================================
+ Hits 0 198 +198
- Misses 0 215 +215 ☔ View full report in Codecov by Sentry. |
|
This PR will trigger no release when merged. |
There was a problem hiding this comment.
Good start point. I am working on exploding the source code to make it "unit testable".
I also think we should merge the rum-js and enhancer repos to have one code source (they work together anyway) with multiple outputs (sampleRUM for Helix projects, standalone, one single file...). But we can discuss next week during the hackathon.
| "test": "web-test-runner --node--resolve --coverage", | ||
| "test:ci": "web-test-runner --node-resolve --coverage --playwright", | ||
| "test:watch": "web-test-runner --node-resolve --coverage --watch", |
There was a problem hiding this comment.
Only chrome is executed by default. For rum-js, I have added chrome, webkit and firefox to cover everything we are interested into. See https://github.com/adobe/helix-rum-js/blob/main/package.json#L8-L10
see suggestion in #191 (comment)
see suggestion in #191 (comment)
|
🎉 This PR is included in version 2.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
see also #192