-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor sourceSelector #215
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 524 551 +27
=========================================
+ Hits 524 551 +27 ☔ View full report in Codecov by Sentry. |
- `img` for images | ||
- `video` for videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something that we don't have right now, but it would be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add object
to support generic embeds, and possibly iframe
/audio
|
||
`context` is | ||
- `form` for form elements | ||
- `dialog` for dialog elements, or parent containers that are fixed positioned and have a positive high z-index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the idea suggested here https://cq-dev.slack.com/archives/C07198KKQ07/p1719245765117359
This PR will trigger a minor release when merged. |
Co-authored-by: Alexandre Capt <acapt@adobe.com>
🎉 This issue has been resolved in version 2.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I'm rethinking how the sourceSelector should work, and started by writing down the spec
If you want to try this, open dev tools on a random page, paste this
move the mouse pointer around on the website and compare the output to your expectations