Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deliver src folder #294

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: deliver src folder #294

wants to merge 2 commits into from

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Sep 26, 2024

Use our infrastructure to deliver the distribution files (which are in the src folder....)

https://dist-deliver--helix-rum-enhancer--adobe.aem.page/src/index.js 200
Do not expose the source: https://dist-deliver--helix-rum-js--adobe.aem.page/modules/index.js 404

Copy link

aem-code-sync bot commented Sep 26, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 26, 2024

Page Scores Audits Google
📱 /src/index.js Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/javascript). PSI
🖥️ /src/index.js Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/javascript). PSI
📱 /modules/index.js PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /modules/index.js PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 63.20755% with 156 lines in your changes missing coverage. Please review.

Project coverage is 84.29%. Comparing base (03be852) to head (47c98f5).

Files with missing lines Patch % Lines
src/index.js 63.20% 156 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main     #294       +/-   ##
============================================
- Coverage   100.00%   84.29%   -15.71%     
============================================
  Files            6        7        +1     
  Lines          569      993      +424     
============================================
+ Hits           569      837      +268     
- Misses           0      156      +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adobe-bot
Copy link
Collaborator

This PR will trigger a minor release when merged.

@bosschaert
Copy link
Contributor

bosschaert commented Sep 26, 2024

Quick question - are the files under /src automatically updated when a release is made?

@kptdobe
Copy link
Contributor Author

kptdobe commented Sep 26, 2024

In theory yes, that's the change in .releaserc. But we'll need to merge and make a release to know...

@kptdobe
Copy link
Contributor Author

kptdobe commented Sep 26, 2024

And the src folder is not necessary in the PR, it should be created by the release. I just added it so we can test the delivery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants