Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify script inclusion when using same domain #201

Closed
cziegeler opened this issue Sep 6, 2024 · 1 comment
Closed

Simplify script inclusion when using same domain #201

cziegeler opened this issue Sep 6, 2024 · 1 comment
Labels
enhancement New feature or request released

Comments

@cziegeler
Copy link
Contributor

Currently if you want to load the scripts via the same domain, it is required to first set window.RUM_BASE before including the script.
That leads to two script tags being required, first one which sets that value, second one loading the rum script (deferred).
Couldn't we use ``document.currentScript.src` in the scripts instead which (if I understand it correctly) would mean that all other scripts (as well as the POSTs) would be done via the same host as the initial script has been loaded from

@cziegeler cziegeler added the enhancement New feature or request label Sep 6, 2024
adobe-bot pushed a commit that referenced this issue Sep 9, 2024
# [2.4.0](v2.3.1...v2.4.0) (2024-09-09)

### Features

* Simplify script inclusion when using same domain ([98073a4](98073a4)), closes [#201](#201)
@adobe-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

2 participants