Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

Generate Request ID #66

Closed
trieloff opened this issue Oct 2, 2018 · 3 comments
Closed

Generate Request ID #66

trieloff opened this issue Oct 2, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@trieloff
Copy link
Contributor

trieloff commented Oct 2, 2018

Fastly and OpenWhisk generate both request and invocation IDs. We should do the same, so that adobe/helix-pipeline#61 can use the request ID instead of the time stamp to tag context dumps. In addition, #17 can then look up dumps from the current request and show them.

@tripodsan
Copy link
Contributor

@trieloff what should be the name of the header ?

@trieloff
Copy link
Contributor Author

trieloff commented Oct 8, 2018

These are the headers we have right now:

< x-openwhisk-activation-id: d1ba8f388c7a4ef0ba8f388c7a8ef06f
< x-request-id: QIp6naPQ7b2FcYiBJG2IqUJuNXmzOm6M
< x-backend-name: 3t7g8apsfQlFyvuHIQn9e8--F_AdobeRuntime
< x-cdn-request-id: 96e14a51-f48e-4978-b9bd-e2154bd0d831

X-CDN-Request-ID (note the capitalization) is the most important.

https://github.com/adobe/helix-cli/blob/9c5c3a1d87992a18494c12c5bd243ee7ae07b8f3/layouts/fastly/helix.vcl#L158-L160

X-Backend-Name: localhost--F_Petridish would be a nice touch.

X-OpenWhisk-Activation-Id and X-Request-Id are generated by OpenWhisk, so that would be a nice touch.

@trieloff
Copy link
Contributor Author

trieloff commented Oct 8, 2018

Related adobe/helix-cli#251

@tripodsan tripodsan assigned tripodsan and unassigned tripodsan Oct 9, 2018
@tripodsan tripodsan added enhancement New feature or request good first issue Good for newcomers labels Oct 9, 2018
@tripodsan tripodsan self-assigned this Oct 10, 2018
tripodsan added a commit that referenced this issue Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants