Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json imexport #19

Merged
merged 5 commits into from
May 2, 2021
Merged

Json imexport #19

merged 5 commits into from
May 2, 2021

Conversation

baubakg
Copy link
Member

@baubakg baubakg commented May 2, 2021

Description

Related Issue

#6
#11
#17

Motivation and Context

This change is related to the importing of ParseDefinitions in JSON

How Has This Been Tested?

Unit tests

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)

Checklist:

  • [ x] I have signed the Adobe Open Source CLA.
  • [ x] My code follows the code style of this project.
  • [x ] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • [ x] I have added tests to cover my changes.
  • [ x] All new and existing tests passed.

@baubakg baubakg added this to the 1.0.4 milestone May 2, 2021
@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #19 (88a7ee0) into master (23307ac) will increase coverage by 0.47%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #19      +/-   ##
============================================
+ Coverage     93.54%   94.02%   +0.47%     
- Complexity      166      179      +13     
============================================
  Files             9       12       +3     
  Lines           403      435      +32     
  Branches         76       76              
============================================
+ Hits            377      409      +32     
  Misses           14       14              
  Partials         12       12              
Impacted Files Coverage Δ Complexity Δ
...va/com/adobe/campaign/tests/logparser/LogData.java 84.93% <ø> (ø) 24.00 <0.00> (ø)
.../com/adobe/campaign/tests/logparser/LogParser.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...campaign/tests/logparser/ParseDefinitionEntry.java 96.07% <ø> (ø) 51.00 <0.00> (ø)
...mpaign/tests/logparser/ParseDefinitionFactory.java 96.00% <96.00%> (ø) 10.00 <10.00> (?)
...dobe/campaign/tests/logparser/ParseDefinition.java 97.22% <100.00%> (+0.07%) 26.00 <0.00> (ø)
...ceptions/ParseDefinitionImportExportException.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...adobe/campaign/tests/logparser/LogDataFactory.java 100.00% <0.00%> (+40.00%) 3.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23307ac...88a7ee0. Read the comment docs.

@baubakg baubakg merged commit 1994240 into master May 2, 2021
@baubakg baubakg deleted the json-imexport branch May 2, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant