Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Next.js config and docs for 13.1 #3897

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Jan 9, 2023

Closes #3895

Updates example app and updates SSR docs to work with Next.js 13.1. Old way with next-transpile-modules is kept in the docs, but collapsed.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  1. Check updated config in example app.
  2. Check updated docs: https://reactspectrum.blob.core.windows.net/reactspectrum/1493d243ca43ec7aa33fa8d041486c38b15604fd/docs/react-spectrum/ssr.html#nextjs

🧢 Your Project:

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to delete the yarn.lock on the example

@reidbarber reidbarber merged commit a437af0 into main Jan 10, 2023
@reidbarber reidbarber deleted the update-nextjs-and-config branch January 10, 2023 23:58
@dannify
Copy link
Member

dannify commented Jan 11, 2023

Looks like this is breaking prod docs

@LFDanLu
Copy link
Member

LFDanLu commented Jan 11, 2023

Reran build, looks like an intermittent failure, prod docs look good now.

@leerob
Copy link

leerob commented Jun 16, 2023

Thank you for updating this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update next.js guide
6 participants