Remove check that Java version output must start with "java version" #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mesbah-Alam <Mesbah_Alam@ca.ibm.com>
Mesbah-Alam
force-pushed
the
remove-exception-for-java-version-check
branch
from
0beb3f0
to
6353fc7
Compare
|
Test : Grinder/16865/ |
pshipton
approved these changes
Jul 9, 2021
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the check for Java version output from JavaVersion.java class from STF.
Background: We do not need to check for java version output's validity in STF, since we have functional tests to check for it and also perform additional tests for it in TKG. Besides, this check over here causes exceptions every time we want to test a new SDK (e.g. STF framework failed to recognize new product name - Semeru eclipse-openj9/openj9#13154).
Note : This PR is part of a larger task of re-implementing how STF figures out Java version - which requires that we first investigate how Java version is used in various STF based tests. We will cover that in a separate PR.
Fixes STF framework failed to recognize new product name - Semeru eclipse-openj9/openj9#13154
Signed-off-by: Mesbah-Alam Mesbah_Alam@ca.ibm.com