Need to add macOS Arm64 spec

[gdams]

As shown in https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk/job/jdk-mac-arm64-hotspot_SmokeTests/8/console

java.lang.AssertionError: Cannot find key PLATFORM: arm64_mac in PLATFORM_MAP

[gdams]

I've temporarily added sw.os.osx hw.arch.arm64 ci.role.test to the build machines until we have more hardware

[smlambert]

https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/55/console - will have to add some prints in the setup stage to understand why it (silently) fails...

[smlambert]

Description
How to address this issue is to add a section in the PLATFORM_MAP in the openjdk_tests file for this platform,

   'arm64_mac' : [
        'SPEC' : 'arm64_mac',
        'LABEL' : 'ci.role.test&&sw.os.osx&&hw.arch.arm64',
    ],

📋 Step by Step

To solve this issue and contribute a fix you should check the following step-by-step list. A more detailed documentation of the workflow can be found here. Note: that you do not need to add yourself to a Contributors.md file as outlined in the detailed instructions.

• Claim this issue: Comment below.
• Fork the repository in github by simply clicking the 'fork' button.
• Check out the forked repository
• Create a feature branch for the issue. We do not have any naming definition for branches.
• Commit your changes (to the openjdk_tests file as described above).
• Start a Pull Request.
• Done 👍 Ask in comments for a review :)
• If the reviewer find some missing pieces or a problem they will start a discussion with you and describe the next steps how the problem can be solved.
• You did it 🎉 We will merge the fix in the master branch.
• Thanks, thanks, thanks for being part of this project as an open source contributor ❤️

[gdams]

@ShelleyLambert looks like you were pointing it at the wrong job number, trying again here: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/61/console

[gdams]

Another test with JDK_REPO set correctly: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/63/console

[smlambert]

Great, Grinder/63 passed. Though we still need to merge in a PR - those Grinders were running off of my branch, no PR created yet.

[gdams]

PR created here #2509

[smlambert]

ha, ok thanks for the fix @gdams, but now you owe me a "good first issue" that can be offered to the 50+ Outreachy candidates. ;)

[sophia-guo]

Talked with @renfeiw there are a couple things need to double check so better to keep this issue open.

System.getProperty('os.arch') get x86_64 instead of os.arch=arm64 . For other arm64 the os.arch is aarch64. @gdams what is expected property of os.arch for this macOS Arm64?

With AUTODETECT on SPEC will be set as osx_x86-64 same to macos linux. That is all functional tests will take maxos Arm64 same as maxos linux. With AUTODETECT off SPEC will be set as arm64_mac, which hasn't been added to TKG. That probably will not work well with functional test.

[gdams]

@sophia-guo I was stupidely cross-compiling the x64 version.

An updated build shows the correct output:

System.getProperty('os.arch')=aarch64