Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arm64_mac in properties file #182

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Add arm64_mac in properties file #182

merged 1 commit into from
Apr 19, 2021

Conversation

renfeiw
Copy link
Contributor

@renfeiw renfeiw commented Apr 15, 2021

Signed-off-by: renfeiw renfeiw@ca.ibm.com

@renfeiw
Add arm64_mac in properties file
0f1a9d1 
Signed-off-by: renfeiw <renfeiw@ca.ibm.com>
@renfeiw renfeiw mentioned this pull request Apr 15, 2021
Merged
smlambert
smlambert approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @renfeiw !

@karianna karianna added the enhancement New feature or request label Apr 16, 2021
@karianna karianna added this to the April 2021 milestone Apr 16, 2021
sophia-guo
sophia-guo reviewed Apr 19, 2021
View reviewed changes
Copy link
Contributor

@sophia-guo sophia-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renfeiw renfeiw merged commit bd40a2e into adoptium:master Apr 19, 2021
@sophia-guo
Copy link
Contributor

Not related with this PR, I would suggest to update the originally PR https://github.com/AdoptOpenJDK/openjdk-tests/pull/2509/files Platform arm64_mac to aarch64_mac. Two reasons:

  1. all other arm64 on linux named as aarch64_linux in both build repo and openjdk-test repo.

https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk/

https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/buildenv/jenkins/openjdk_tests#L12

  1. Using arm64 is just a accident Need to add macOS Arm64 spec aqa-tests#2501 (comment)

@renfeiw renfeiw mentioned this pull request May 11, 2021
Merged
@renfeiw renfeiw mentioned this pull request May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@sophia-guo sophia-guo sophia-guo approved these changes

@Arioobarzann Arioobarzann Arioobarzann approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
April 2021
Development

Successfully merging this pull request may close these issues.
5 participants
@renfeiw @sophia-guo @smlambert @Arioobarzann @karianna