Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having build unzip issues due to nested zip in jenkins submission on windows platforms. #5661

Closed
wants to merge 3 commits into from

Conversation

prodroy89
Copy link
Contributor

Having build unzip issues due to nested zip in jenkins submission on windows platforms.

Fixes is given here:- https://github.com/prodroy89/aqa-tests/blob/8af20858dcfa4480057f6075b3c7abd743098db3/get.sh#L313

Signed-off-by: Prodip Roy prodroy89@in.ibm.com

@llxia
Copy link
Contributor

llxia commented Oct 3, 2024

@prodroy89 Please do the following:

  • Please squash the commits
  • Update the tile to reflect the change
  • Please provide a Grinder link

@prodroy89
Copy link
Contributor Author

Hi @llxia , I have given details in below, thanks.
Please squash the commits
Here only 2 commits,

  1. Merge branch 'adoptium:master' into build_issues_windows
  2. And code chnages:- Update get.sh by using '' in zip

Update the tile to reflect the change
https://github.com/prodroy89/aqa-tests/blob/8af20858dcfa4480057f6075b3c7abd743098db3/get.sh#L313
image

Please provide a Grinder link
Nested zip issues
Ref. Link:- https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/24128/

After changes the code unzipping issues gone

single link:- https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/24115/
Grinder link:- https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder_CR/24394/

Thanks.

@llxia
Copy link
Contributor

llxia commented Oct 4, 2024

Please squash the commits

Please squash your 2 commits into one. See https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together

Update the tile to reflect the change

Change PR tile Having build unzip issues due to nested zip in jenkins submission on windows platforms. and commit title to Add quote around *.zip

@prodroy89
Copy link
Contributor Author

Hi @llxia, I had done the changes from GUI in aqa-tests for this PR, that's why it's not allowing me to squash the commits into one commit. I have done the changes freshly from git terminal now and created into one commit.
So I am attaching that new PR link here #5665 and closing this PR.

Thanks.

@prodroy89 prodroy89 closed this Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants