Skip to content

Commit

Permalink
unixPB: improves download and verify of ant binary
Browse files Browse the repository at this point in the history
by replacing `command: wget` with `get_url` module, it helps to support more systems. Also while running `GPG Signature verification` some systems (e.g old mac machines) have problem with wget while running `package_signature_verification.sh`. This change makes sure all systems will find wget in their `PATH`.

Sigend-off-by: mahdi@ibm.com
  • Loading branch information
mahdipub committed Sep 30, 2024
1 parent d483066 commit ab3560a
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
tags: ant

- name: Download Apache Ant binaries (macOS) and (Solaris)
command: wget https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.5-bin.zip -O /tmp/apache-ant-1.10.5-bin.zip
get_url:

Check failure on line 32 in ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/ant/tasks/main.yml

View workflow job for this annotation

GitHub Actions / Yamllint

32:11 [trailing-spaces] trailing spaces

Check failure on line 32 in ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/ant/tasks/main.yml

View workflow job for this annotation

GitHub Actions / Ansible Lint

yaml[trailing-spaces]

Trailing spaces
url: https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.5-bin.zip
dest: /tmp/apache-ant-1.10.5-bin.zip
when:
- ant_installed.rc != 0
- ansible_distribution == "MacOSX" or ansible_distribution == "Solaris"
Expand All @@ -46,6 +48,8 @@
- name: GPG Signature verification
script: ../Supporting_Scripts/package_signature_verification.sh -f /tmp/apache-ant-1.10.5-bin.zip -sl "https://archive.apache.org/dist/ant/binaries/apache-ant-1.10.5-bin.zip.asc" -k {{ key.apache_ant }}
when: ant_installed.rc != 0
environment:
PATH: "{{ ansible_env.PATH }}:/usr/local/bin:/usr/local/sbin:/usr/bin:/bin:/usr/sbin:/sbin"
tags: ant

- name: Extract ant
Expand Down

0 comments on commit ab3560a

Please sign in to comment.