Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unixPB: Install capstone 4 from repositories or source #3119

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

sxa
Copy link
Member

@sxa sxa commented Jun 30, 2023

Checklist

This is the machine setup part of #hsdis

@sxa sxa marked this pull request as draft July 3, 2023 09:18
@sxa
Copy link
Member Author

sxa commented Jul 3, 2023

Moving back to draft until I put the changes in to restrict build by architecture to reduce library size. Also awaiting on merge of #3120 which is preventing the VPC checks from passing.

@sxa
Copy link
Member Author

sxa commented Jul 3, 2023

Updated to only build one platform for each build to reduce library size.

Rebasing on top of maven signature PR which has now been merged: https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1692/

@sxa
Copy link
Member Author

sxa commented Jul 3, 2023

Need to consider whether using the default compiler on each machine is sensible given that this is a library which will be reshipped...

@sxa sxa force-pushed the linux_capstone branch 10 times, most recently from 93e2879 to f3ed08f Compare July 8, 2023 18:56
@sxa
Copy link
Member Author

sxa commented Jul 9, 2023

Latest VPC run (linked in the description) looks like it has run through without problems related to this PR.

@sxa sxa self-assigned this Jul 9, 2023
@sxa sxa marked this pull request as ready for review July 9, 2023 11:54
@sxa sxa marked this pull request as draft July 11, 2023 11:00
@sxa
Copy link
Member Author

sxa commented Jul 11, 2023

Converting back to draft due to consideration of having a pre-built versions stored on our servers that is downloaded during the build process in order to ensure reproducibility.

@sxa
Copy link
Member Author

sxa commented Oct 5, 2023

Testing along with the corresponding build script changes in VPC 1729

@sxa
Copy link
Member Author

sxa commented Oct 5, 2023

Re-running with the updates + rebase of the infrastructure PR, and updates to the build PR to move all the selection logic into linux.sh: https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1730/

@sxa
Copy link
Member Author

sxa commented Oct 5, 2023

Noting that this is not in the DockerStatic role but since there are no tests requiring this yet that is not a requirement.

@sxa sxa marked this pull request as ready for review October 6, 2023 12:13
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxa
Copy link
Member Author

sxa commented Oct 6, 2023

Re-running with the updates + rebase of the infrastructure PR, and updates to the build PR to move all the selection logic into linux.sh: https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1730/

Slightly concerned by the test case failures showing here, but that was are using the main development branch of JDK22 so i don't think it's related ...

running https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1731 with JDK21.

@karianna
Copy link
Contributor

karianna commented Oct 7, 2023

@sxa
Copy link
Member Author

sxa commented Oct 8, 2023

https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1731

Failed sadly.

Looks like it was due to a bunch of hung processes causing the failures (Except the ones that were showing a yellow warning status which were due to the MBCS tests failing - suspect we'll need to look at that separately since the test may no longer be valid for JDK21+ ...

New run after clearing processes ir running better: https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1732/

@sxa
Copy link
Member Author

sxa commented Oct 9, 2023

1732 mostly worked other than Solaris 10 which had an issue downloading the Liberica JDK11.
The yellow warning triangles are due to an issue with the MBCS tests on later versions of the JDK which I will raise another issue to investigate.

@sxa sxa merged commit 87b659e into adoptium:master Oct 9, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants