Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unixPb: Update Ant version to latest 1.10.15 #3747

Merged
merged 5 commits into from
Oct 4, 2024
Merged

unixPb: Update Ant version to latest 1.10.15 #3747

merged 5 commits into from
Oct 4, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Sep 25, 2024 •
edited
Loading

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #3074

To do:

  • Build each modified static container's dockerfile
  • Test playbook changes
  • Run AQA pipelines on affected static containers and machines

@Haroon-Khel
Copy link
Contributor Author

VPC https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1964/console

@Haroon-Khel
Copy link
Contributor Author

Latest vpc https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1965/console

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Sep 26, 2024 •
edited
Loading

Ant updated to v1.10.15 on the following static docker machines

test-docker-amazon2023-x64-1 https://ci.adoptium.net/job/AQA_Test_Pipeline/355/console

test-docker-fedora41-x64-1 https://ci.adoptium.net/job/AQA_Test_Pipeline/356/console

test-docker-debian12-x64-4 https://ci.adoptium.net/job/AQA_Test_Pipeline/357/console

test-docker-ubuntu2404-x64-1 https://ci.adoptium.net/job/AQA_Test_Pipeline/358/console

test-docker-ubi9-x64-1 https://ci.adoptium.net/job/AQA_Test_Pipeline/359/console

test-docker-fedora41-armv8-1 https://ci.adoptium.net/job/AQA_Test_Pipeline/360/console

test-docker-ubuntu2404-armv8-1 https://ci.adoptium.net/job/AQA_Test_Pipeline/361/console

test-docker-sles12-s390x-1 https://ci.adoptium.net/job/AQA_Test_Pipeline/362/console

test-docker-sles15-s390x-1 https://ci.adoptium.net/job/AQA_Test_Pipeline/363/console

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Sep 27, 2024 •
edited
Loading

Testing ant v1.10.15 on vms

test-azure-ubuntu2404-x64-1 https://ci.adoptium.net/job/AQA_Test_Pipeline/364/console

test-osuosl-ubuntu2404-aarch64-1 https://ci.adoptium.net/job/AQA_Test_Pipeline/367/console

test-marist-rhel8-s390x-2 https://ci.adoptium.net/job/AQA_Test_Pipeline/369/console

test-marist-sles15-s390x-2 https://ci.adoptium.net/job/AQA_Test_Pipeline/370/console

@Haroon-Khel
Copy link
Contributor Author

Latest vpc https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1966/console

@Haroon-Khel Haroon-Khel mentioned this pull request Sep 30, 2024
Merged
6 tasks
@Haroon-Khel
Copy link
Contributor Author

Results from test-azure-ubuntu2404-x64-1 https://ci.adoptium.net/job/AQA_Test_Pipeline/364/console

Various failures. Going to rerun them on the same machine to see if theyre related to the Ant upgrade. If they continue to fail then Ill try rerunning them on the same machine with a rolled back version of Ant to see if they still fail.

Rerun with Ant v1.10.15:
JDK 8

JDK 11

JDK 17

JDK 21

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Oct 2, 2024 •
edited
Loading

Since the test failures on test-azure-ubuntu2404-x64-1 are persistent with ant v1.10.15, I am going to roll back the version of ant and rerun the tests

Rerun with Ant v1.10.5:
JDK 8

JDK 11

JDK 17

JDK 21

Update The tests still fail on the rolled back Ant version. The test failures are unrelated with the version of Ant

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Oct 3, 2024 •
edited
Loading

Testing SBOM generation with Ant v1.10.15:

AIX build on build-osuosl-aix72-ppc64-2 https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk17u/job/jdk17u-aix-ppc64-temurin/405/console Update ✅

For our linux builds, I am running a JDK21 linux build in an adoptium/centos7 build container with an upgraded version of Ant. Update ✅

The windows machines are not idle at the moment, so I will test on them later
Update https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk17u/job/jdk17u-windows-x64-temurin/530/console ✅

steelhead31
steelhead31 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, approving on the basis its been tested :)

@Haroon-Khel Haroon-Khel merged commit f752b77 into adoptium:master Oct 4, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@steelhead31 steelhead31 steelhead31 approved these changes

@sxa sxa Awaiting requested review from sxa

Assignees
No one assigned
Labels
ansible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Haroon-Khel @karianna @steelhead31