Update reproducible comparing on linux #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
x-linux
sophia-guo
force-pushed
the
linuxR
branch
2 times, most recently
from
db07c8e
to
aae887a
Compare
sophia-guo
force-pushed
the
linuxR
branch
4 times, most recently
from
ca3d695
to
2eee94c
Compare
4 tasks
andrew-m-leonard
requested changes
Sep 4, 2024
tooling/reproducible/repro_common.sh
Outdated
| rm -rf "$JDK_DIR/NOTICE" | ||
|
|
||
| if [[ "$OS" =~ Linux ]]; then | ||
| find "$JDK_DIR/" -type f -name "*.debuginfo" -delete |
There was a problem hiding this comment.
I don't think removing the debuginfo here is the right thing to do, we should ensure only the JDK tarball is unpacked
Also, the "release" file should not be totally ignored, only the specific Temurin lines should be removed, as in cleanTemurinBuildInfo()
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
karianna
approved these changes
Sep 4, 2024
andrew-m-leonard
requested changes
Sep 5, 2024
sophia-guo
force-pushed
the
linuxR
branch
3 times, most recently
from
b6cb0f0
to
cec8345
Compare
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
andrew-m-leonard
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3920
Using common compare script
Remove non-revolant files
Remove debuginfo if exists from aqa-tests level