Enable Mac Aarch64 reproducible comparing tests #3972
+91
−173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
github-actions
bot
added
the
aarch
sophia-guo
commented
Oct 4, 2024
tooling/reproducible/repro_common.sh
Outdated
| @@ -234,7 +237,7 @@ function removeMacOSNonComparableData() { | |||
| else | |||
| # Format uuid for BINREPL | |||
| uuidhex="${uuid:0:2}:${uuid:2:2}:${uuid:4:2}:${uuid:6:2}:${uuid:8:2}:${uuid:10:2}:${uuid:12:2}:${uuid:14:2}:${uuid:16:2}:${uuid:18:2}:${uuid:20:2}:${uuid:22:2}:${uuid:24:2}:${uuid:26:2}:${uuid:28:2}:${uuid:30:2}" | |||
| if ! java "$TEMURIN_TOOLS_BINREPL" --inFile "$f" --outFile "$f" --hex "${uuidhex}-AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA" --firstOnly; then | |||
| if ! "${JDK_DIR}"/bin/java "$TEMURIN_TOOLS_BINREPL" --inFile "$f" --outFile "$f" --hex "${uuidhex}-AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA" --firstOnly; then | |||
There was a problem hiding this comment.
@andrew-m-leonard this line got the error
00:18:45 Failed setting boot class path.
00:18:45 FAILED ==> java "temurin.tools.BinRepl" --inFile "src_jdk/Contents/Home/../../Contents/Home/bin/jwebserver" --outFile "src_jdk/Contents/Home/../../Contents/Home/bin/jwebserver" --hex "8C:04:09:F5:4F:35:3A:EB:B0:C1:42:BF:D8:09:D4:D5-AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA:AA" --firstOnly
https://ci.adoptium.net/view/Test_grinder/job/Grinder/11059/console
Any suggestions?
There was a problem hiding this comment.
@sophia-guo it looks like the "java" being used is not working, is the PATH set correctly to find a useable JDK?
05:18:45 Error occurred during initialization of VM
05:18:45 Failed setting boot class path.
There was a problem hiding this comment.
It was set to the tests jdk if ! "${JDK_DIR}"/bin/java" same as for the javap. Did you mean this is different from the javap, we can use whatever workable java? As I did notice that after we did the preprocess of the jdk ( remove signartures), java doesn't work any more.
sophia-guo
force-pushed
the
macAarch
branch
2 times, most recently
from
541225c
to
21abf49
Compare
sophia-guo
force-pushed
the
macAarch
branch
2 times, most recently
from
3e41e3c
to
25cbffc
Compare
karianna
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.