Use optimized filepath.WalkDir function instead of filepath.Walk #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hismailbulut. Thank you for the PR. I would love to adopt this change at this point. However That means that I would force the Go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple test shows the performance difference
Test with filepath.Walk:
goos: windows
goarch: amd64
pkg: github.com/adrg/sysfont
cpu: Intel(R) Core(TM)2 Quad CPU Q9400 @ 2.66GHz
BenchmarkNewFinder-4 3 466802100 ns/op
PASS
ok github.com/adrg/sysfont 2.978s
Test with filepath.WalkDir:
goos: windows
goarch: amd64
pkg: github.com/adrg/sysfont
cpu: Intel(R) Core(TM)2 Quad CPU Q9400 @ 2.66GHz
BenchmarkNewFinder-4 3 427294700 ns/op
PASS
ok github.com/adrg/sysfont 2.743s