Skip to content

Commit

Permalink
nodejs: disable JS test suite on Darwin
Browse files Browse the repository at this point in the history
This was recently enabled in NixOS#313982. It seems to be much too flaky
on Darwin currently, especially x86; see:

* <https://hydra.nixos.org/build/264860513/nixlog/8>
* <https://hydra.nixos.org/build/264956149/nixlog/3>
* <https://hydra.nixos.org/build/265094929/nixlog/3>
* <https://hydra.nixos.org/build/264901296/nixlog/3>

Disable these tests on macOS for now as the broken Node.js package
is holding up a lot of builds.

Fixes: b26563a
(cherry picked from commit d25d9b6)
  • Loading branch information
emilazy authored and aduh95 committed Jul 11, 2024
1 parent a168fae commit 1a9ad9b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkgs/development/web/nodejs/nodejs.nix
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ let
"build-node-api-tests"
"tooltest"
"cctest"
] ++ lib.optionals (!stdenv.buildPlatform.isDarwin || lib.versionAtLeast version "20") [
] ++ lib.optionals (!stdenv.buildPlatform.isDarwin) [
# There are some test failures on macOS before v20 that are not worth the
# time to debug for a version that would be eventually removed in less
# than a year (Node.js 18 will be EOL at 2025-04-30). Note that these
Expand All @@ -158,7 +158,7 @@ let
checkFlags = [
# Do not create __pycache__ when running tests.
"PYTHONDONTWRITEBYTECODE=1"
] ++ lib.optionals (!stdenv.buildPlatform.isDarwin || lib.versionAtLeast version "20") [
] ++ lib.optionals (!stdenv.buildPlatform.isDarwin) [
"FLAKY_TESTS=skip"
# Skip some tests that are not passing in this context
"CI_SKIP_TESTS=${lib.concatStringsSep "," ([
Expand Down

0 comments on commit 1a9ad9b

Please sign in to comment.