Skip to content

Commit

Permalink
Remove unneeded events used specific for rerender, the entityupdate e…
Browse files Browse the repository at this point in the history
…vent is enough here
  • Loading branch information
vincentfretin committed Dec 7, 2023
1 parent 2b202c2 commit d3042a8
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 21 deletions.
4 changes: 0 additions & 4 deletions src/components/components/CommonComponents.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ export default class CommonComponents extends React.Component {
}
});

Events.on('refreshsidebarobject3d', () => {
this.forceUpdate();
});

var clipboard = new Clipboard('[data-action="copy-entity-to-clipboard"]', {
text: (trigger) => {
return getEntityClipboardRepresentation(this.props.entity);
Expand Down
13 changes: 0 additions & 13 deletions src/components/components/PropertyRow.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,6 @@ export default class PropertyRow extends React.Component {
constructor(props) {
super(props);
this.id = props.componentname + ':' + props.name;

if (
['position', 'rotation', 'scale'].indexOf(this.props.componentname) !== -1
) {
Events.on(
'entitytransformed',
debounce((entity) => {
if (entity === props.entity) {
this.forceUpdate();
}
}, 250)
);
}
}

getWidget() {
Expand Down
4 changes: 0 additions & 4 deletions src/lib/viewport.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ export function Viewport(inspector) {

updateHelpers(object);

Events.emit('refreshsidebarobject3d', object);

// Emit update event for watcher.
let component;
let value;
Expand Down Expand Up @@ -85,8 +83,6 @@ export function Viewport(inspector) {
property: '',
value: value
});

Events.emit('entitytransformed', transformControls.object.el);
});

transformControls.addEventListener('mouseDown', () => {
Expand Down

0 comments on commit d3042a8

Please sign in to comment.